SIDDARTHAREDDY8/dhp

Review signals: 1 download and execute, 2 known vulnerability.

Reviewed as expected for a test run: attempted writes that failed, so nothing was written.

Source contains download and execute; review its purpose. install.sh

OSV reports a known vulnerability in this dependency version. certifi 2 findings.

OSV scanned supported lockfiles; unpinned dependencies and unsupported formats are outside this check.

A short run cannot establish that code is safe.

Connections show IP addresses; proxies can hide the final hostname.

Tracing covers dispatched commands and their children, not the whole OS; guest root can interfere with tracing.

Full safety evidence →

• The MCP server is started with dhp-mcp --root and rejects a malformed handoff ID: Real input produced the expected result: malformed handoff_id (want 64 lowercase hex chars)

  Source: run `dhp-mcp --root <dir>` and point any MCP client at it.

  Input: {"tool": "dhp_status", "arguments": {"handoff_id": "not-a-handoff"}}

  Expected: ValidationError: malformed handoff_id (want 64 lowercase hex chars)

  Command: <guest-path> --root <guest-path> tools/call {"tool": "dhp_status", "arguments": {"handoff_id": "not-a-handoff"}}

  Observed: malformed handoff_id (want 64 lowercase hex chars)\", \"code\": \"ValidationError\"}", "type": "text"}], "isError": false, "structuredContent": {"result": "{\"ok\": false, \"error\": \"malformed handoff_id (want 64 lowercase hex chars)\", \"code\": \"ValidationError\"}"}}

Examples

• Run the conformance suite (README Contributing: dhp-conform reports 10/10): command completed successfully

  Source: README.md Contributing section

  Input: no arguments

  Expected: 10 passed, 0 failed

  Command: <guest-path>

  Observed: nformance suite (v0.4): PASS no-lost-results PASS no-crossed-inputs PASS no-untyped-results PASS no-silent-budget-overrun PASS no-runner-lock-in PASS exactly-one-wins PASS fencing PASS leader-election PASS transport PASS dead-letter-queue 10 passed, 0 failed complete aed2c1c311af: schema failure → DLQ: result violates output_schema: 'x' is a required property Failed validating 'required' in schema: {'type': 'object', 'properties': {'x': {'type': 'integer'}}, 'required': ['x']} On instance: {'wrong': 'shape'} orphan dc32c4cbf057: DLQ (attempt 1 >= max 1)

• Run the pytest suite documented in README Contributing; warnings plugin disabled and the test that hardcodes a missing author path deselected: command completed successfully

  Source: README.md Contributing section

  Input: tests/ -q, -p no:warnings, deselect test_kill9_during_writes

  Expected: 59 passed, 1 deselected

  Command: <guest-path> -m pytest tests/ -q -p no:warnings --deselect tests/test_adversarial.py::test_kill9_during_writes

  Observed: ........................................................... [100%] 59 passed, 1 deselected in 22.64s

Cycles

• The supervisor runs a periodic lease scan loop until its duration elapses: Triggered one cycle by hand (run-once: dhp-supervisor with a 2 second duration (manual trigger, no source edits); normal trigger: scan every supervisor_scan_s (default 1.0s) for the duration given on the command line): { "supervisor": "sup1", "was_leader": true, "actions": [], "metrics": { "scans": 2, "orphans": 0, "dlq": 0, "leadership_changes": 1, "errors": 0, "uptime_s": 2.0 } } 2026-10-25 23:05:00,684 INFO [dhp] store: initialized schema v3 at <guest-path> 2026-10-25 23:05:00,685 INFO [dhp] supervisor sup1: watching (scan every 1.0s) 2026-10-25 23:05:00,688 INFO [dhp] supervisor sup1: became leader 2026-10-25 23:05:02,694 INFO [dhp] supervisor sup1: stopped (0 actions)

  Source: dhp/supervisor3.py

  Input: root <guest-path>, supervisor id sup1, 2 seconds

  Expected: two scans run, leader elected, JSON summary printed

  Command: <guest-path> <guest-path> sup1 2

  Observed: { "supervisor": "sup1", "was_leader": true, "actions": [], "metrics": { "scans": 2, "orphans": 0, "dlq": 0, "leadership_changes": 1, "errors": 0, "uptime_s": 2.0 } } 2026-10-25 23:05:00,684 INFO [dhp] store: initialized schema v3 at <guest-path> 2026-10-25 23:05:00,685 INFO [dhp] supervisor sup1: watching (scan every 1.0s) 2026-10-25 23:05:00,688 INFO [dhp] supervisor sup1: became leader 2026-10-25 23:05:02,694 INFO [dhp] supervisor sup1: stopped (0 actions)

Local or hosted: local

Start the DHP MCP server (dhp-mcp --root <dir>) and dispatch/validate durable work through its tools

cd <guest-path> && pwd && ls -la && id -u && python3 --version && cat README.md 2>/dev/null | head -c 6000
cd <guest-path> && tail -c +6000 README.md | head -c 7000
cd <guest-path> && cat install.sh; cat pyproject.toml; ls .coldpass dhp scripts tests demo daily; cat .coldpass/* 2>/dev/null | head -c 2000
cd <guest-path> && grep -n -i "mcp\|pytest\|test\|venv\|pip install\|--root\|cycle\|cron\|daily" README.md | head -80
cd <guest-path> && sed -n 340,370p README.md; sed -n 410,425p README.md
cd <guest-path> && python3 -m venv <guest-path> 2>&1 | tail -3; ls <guest-path> 2>/dev/null | head
cd <guest-path> && <guest-path> -m pip install -q -e ".[dev]" 2>&1 | tail -15; echo EXIT=$?; ls <guest-path> | grep dhp
cd <guest-path> && timeout 900 <guest-path> -m pytest tests/ -q 2>&1 | tail -8; echo; timeout 300 <guest-path> 2>&1 | tail -15; echo EXIT=$?
cd <guest-path> && timeout 300 <guest-path> -m pytest tests/test_adversarial.py::test_kill9_during_writes -q 2>&1 | grep -v Warning | grep -E "Error|error|assert|FAILED|passed|failed|sqlite" | head -20
cd <guest-path> && sed -n 95,130p tests/test_adversarial.py
cd <guest-path> && grep -n "sqlite3\"\|\.sqlite\|dhp.db\|\.db\"" dhp/store.py | head; ls <host-path> 2>&1 | head -1
cd <guest-path> && <guest-path> -c "import sys; sys.path.insert(0, '<host-path>'); import dhp; from tests.conftest import SCHEMA; print('imports ok')" 2>&1 | tail -3
cd <guest-path> && grep -n "def dhp_\<email>\<email>\|def _tool\|name=" dhp/mcp_server.py | head -60
cd <guest-path> && sed -n 40,100p dhp/mcp_server.py; sed -n 180,192p dhp/mcp_server.py
mkdir -p <guest-path> && cd <guest-path> && ( printf '%s\n' '{"jsonrpc":"2.0","id":1,"method":"initialize","params":{"protocolVersion":"2025-06-18","capabilities":{},"clientInfo":{"name":"t","version":"1"}}}' '{"jsonrpc":"2.0","method":"notifications/initialized"}' '{"jsonrpc":"2.0","id":2,"method":"tools/call","params":{"name":"dhp_dispatch","arguments":{"task_kind":"demo.count","inputs":{"target":50},"output_schema":{"type":"object"}}}}' ; sleep 2 ) | timeout 60 <guest-path> --root <guest-path> 2><guest-path> | tail -c 1500; echo; echo EXIT=$?; tail -5 <guest-path>
mkdir -p <guest-path> && cd <guest-path> && cat > probe.json <<'EOF'
{"kind":"mcp","argv":["<guest-path>","--root","<guest-path>"],"cwd":"<guest-path>","tool":"dhp_dispatch","arguments":{"task_kind":"demo.count","inputs":{"target":50},"output_schema":{"type":"object"}},"expected_text":"cf7ec797ce52cd7b650b090180a804f28ac7cc63864c3c578c3aa2c947f314bf","env":{}}
EOF
cat > claims.json <<'EOF'
[{"kind":"claim","claim":"The MCP server is started with dhp-mcp --root and dispatching work returns a handoff ID","source":"run `dhp-mcp --root <dir>` and point any MCP client at it.","input":"task_kind demo.count, inputs target 50","expected":"ok true with handoff_id cf7ec797ce52cd7b650b090180a804f28ac7cc63864c3c578c3aa2c947f314bf","probe_kind":"mcp","argv":["<guest-path>","--root","<guest-path>"],"tool":"dhp_dispatch","arguments":{"task_kind":"demo.count","inputs":{"target":50},"output_schema":{"type":"object"}},"expected_text":"cf7ec797ce52cd7b650b090180a804f28ac7cc63864c3c578c3aa2c947f314bf","env":{},"cwd":"<guest-path>"}]
EOF
python3 -m json.tool probe.json >/dev/null && python3 -m json.tool claims.json >/dev/null && echo OK; grep -n "run \`dhp-mcp --root <dir>\` and point any MCP client at it." <guest-path>
cd <guest-path> && timeout 240 <guest-path> demo/run_mad_demo.py > <guest-path> 2>&1; echo EXIT=$?; tail -25 <guest-path>
cd <guest-path> && sed -n 30,50p demo/run_mad_demo.py; grep -n "home/hatch" -r demo dhp scripts tests | head; grep -n "__file__\|BASE\|ROOT" demo/run_mad_demo.py | head
cd <guest-path> && cat dhp/supervisor3_watch.py | head -60; echo ----; cat scripts/daily_loop.sh | head -30; echo ----; grep -rn "schedule\|cron" .github | head -5
cd <guest-path> && timeout 60 <guest-path> <guest-path> sup1 2 2><guest-path>; echo EXIT=$?; tail -3 <guest-path>; ls <guest-path> 2>&1
cd <guest-path> && grep -n "def watch" -A 12 dhp/supervisor3.py; grep -n "scan_s\|SCAN_S" dhp/config.py dhp/supervisor3.py | head -5
rm -rf <guest-path> <guest-path> && cd <guest-path> && cat > cycles.json <<'EOF'
{"detected":true,"checks":[{"claim":"The supervisor runs a periodic lease scan loop until its duration elapses","source":"dhp/supervisor3.py","quote":"while time.time() < end and not self._stop.is_set():","schedule":"scan every supervisor_scan_s (default 1.0s) for the duration given on the command line","method":"run-once: dhp-supervisor with a 2 second duration (manual trigger, no source edits)","input":"root <guest-path>, supervisor id sup1, 2 seconds","expected":"two scans run, leader elected, JSON summary printed","kind":"cli","argv":["<guest-path>","<guest-path>","sup1","2"],"cwd":"<guest-path>","expected_text":"\"was_leader\": true"}]}
EOF
cat > examples.json <<'EOF'
[{"kind":"example","claim":"Run the conformance suite (README CONTRIBUTING: dhp-conform reports 10/10)","source":"README.md Contributing section","input":"no arguments","expected":"10 passed, 0 failed","argv":["<guest-path>"],"cwd":"<guest-path>","env":{},"expected_text":"10 passed, 0 failed"},{"kind":"example","claim":"Run the pytest suite documented in README Contributing; one test deselected because it hardcodes a missing author path and fails here","source":"README.md Contributing section","input":"tests/ -q with --deselect of test_kill9_during_writes","expected":"all other tests pass","argv":["<guest-path>","-m","pytest","tests/","-q","--deselect","tests/test_adversarial.py::test_kill9_during_writes"],"cwd":"<guest-path>","env":{},"expected_text":"passed"}]
EOF
python3 -m json.tool cycles.json >/dev/null && python3 -m json.tool examples.json >/dev/null && echo OK; grep -n "while time.time() < end and not self._stop.is_set():" <guest-path>; grep -n "dhp-conform                   # 10/10" <guest-path>
cd <guest-path> && <env-var>=<guest-path> timeout 900 python3 -I <guest-path> --validate --replay 2>&1 | tail -60; echo EXIT=$?
cd <guest-path> && timeout 300 <guest-path> -m pytest tests/ -q -p no:warnings --deselect tests/test_adversarial.py::test_kill9_during_writes 2>&1 | tail -6; echo EXIT=$?; grep -n "accept" dhp/net.py | head -3
cd <guest-path> && cat > probe.json <<'EOF'
{"kind":"mcp","argv":["<guest-path>","--root","<guest-path>"],"cwd":"<guest-path>","tool":"dhp_dispatch","arguments":{"task_kind":"demo.count","inputs":{"target":50},"output_schema":{"type":"object"}},"expected_text":"\"ok\": true","env":{}}
EOF
cat > claims.json <<'EOF'
[{"kind":"claim","claim":"The MCP server is started with dhp-mcp --root and dispatching work returns a handoff ID","source":"run `dhp-mcp --root <dir>` and point any MCP client at it.","input":"task_kind demo.count, inputs target 50","expected":"ok true with a handoff_id","probe_kind":"mcp","argv":["<guest-path>","--root","<guest-path>"],"tool":"dhp_dispatch","arguments":{"task_kind":"demo.count","inputs":{"target":50},"output_schema":{"type":"object"}},"expected_text":"\"ok\": true","env":{},"cwd":"<guest-path>"}]
EOF
cat > examples.json <<'EOF'
[{"kind":"example","claim":"Run the conformance suite (README Contributing: dhp-conform reports 10/10)","source":"README.md Contributing section","input":"no arguments","expected":"10 passed, 0 failed","argv":["<guest-path>"],"cwd":"<guest-path>","env":{},"expected_text":"10 passed, 0 failed"},{"kind":"example","claim":"Run the pytest suite documented in README Contributing; warnings plugin disabled and the test that hardcodes a missing author path deselected","source":"README.md Contributing section","input":"tests/ -q, -p no:warnings, deselect test_kill9_during_writes","expected":"59 passed, 1 deselected","argv":["<guest-path>","-m","pytest","tests/","-q","-p","no:warnings","--deselect","tests/test_adversarial.py::test_kill9_during_writes"],"cwd":"<guest-path>","env":{},"expected_text":"59 passed, 1 deselected"}]
EOF
for f in probe claims examples cycles; do python3 -m json.tool $f.json >/dev/null && echo "$f ok"; done; rm -rf <guest-path> <guest-path> <guest-path>
cd <guest-path> && <env-var>=<guest-path> timeout 900 python3 -I <guest-path> --validate --replay > <guest-path> 2>&1; echo EXIT=$?; python3 -c "
import json,sys
d=json.load(open('<guest-path>'))
print('valid:',d.get('valid'))
for p in d.get('problems',[]): print('PROBLEM:',str(p)[:600])
" 2>&1 | head -40
grep -n "did not confirm" -B 25 <guest-path> | head -80
cd <guest-path> && ( printf '%s\n' '{"jsonrpc":"2.0","id":1,"method":"initialize","params":{"protocolVersion":"2025-06-18","capabilities":{},"clientInfo":{"name":"t","version":"1"}}}' '{"jsonrpc":"2.0","method":"notifications/initialized"}' '{"jsonrpc":"2.0","id":2,"method":"tools/call","params":{"name":"dhp_status","arguments":{"handoff_id":"not-a-handoff"}}}' ; sleep 1 ) | timeout 60 <guest-path> --root <guest-path> 2>/dev/null | tail -1; rm -rf <guest-path>
cd <guest-path> && ( printf '%s\n' '{"jsonrpc":"2.0","id":1,"method":"initialize","params":{"protocolVersion":"2025-06-18","capabilities":{},"clientInfo":{"name":"t","version":"1"}}}' '{"jsonrpc":"2.0","method":"notifications/initialized"}' '{"jsonrpc":"2.0","id":2,"method":"tools/call","params":{"name":"dhp_status","arguments":{"handoff_id":"not-a-handoff"}}}' ; sleep 3 ) | timeout 60 <guest-path> --root <guest-path> 2><guest-path> | tail -n 2 | cut -c1-600; echo; tail -3 <guest-path>; rm -rf <guest-path>
cd <guest-path> && cat > probe.json <<'EOF'
{"kind":"mcp","argv":["<guest-path>","--root","<guest-path>"],"cwd":"<guest-path>","tool":"dhp_status","arguments":{"handoff_id":"not-a-handoff"},"expected_text":"malformed handoff_id (want 64 lowercase hex chars)","env":{}}
EOF
cat > claims.json <<'EOF'
[{"kind":"claim","claim":"The MCP server is started with dhp-mcp --root and rejects a malformed handoff ID","source":"run `dhp-mcp --root <dir>` and point any MCP client at it.","input":"handoff_id not-a-handoff","expected":"ValidationError: malformed handoff_id (want 64 lowercase hex chars)","probe_kind":"mcp","argv":["<guest-path>","--root","<guest-path>"],"tool":"dhp_status","arguments":{"handoff_id":"not-a-handoff"},"expected_text":"malformed handoff_id (want 64 lowercase hex chars)","env":{},"cwd":"<guest-path>"}]
EOF
for f in probe claims; do python3 -m json.tool $f.json >/dev/null && echo "$f ok"; done; ls <guest-path>
rm -rf <guest-path> <guest-path> <guest-path> && cd <guest-path> && <env-var>=<guest-path> timeout 900 python3 -I <guest-path> --validate --replay > <guest-path> 2>&1; echo EXIT=$?; python3 -c "
import json
d=json.load(open('<guest-path>'))
print('valid:',d.get('valid'))
for p in d.get('problems',[]): print('PROBLEM:',str(p)[:700])
" 2>&1 | head -30
pgrep -af "dhp-mcp|dhp-supervisor|run_mad_demo|transport" || echo "no dhp processes"; rm -rf <guest-path> <guest-path> <guest-path> /tmp/dhp-mad-demo; ls <guest-path>; ls <guest-path>
cd <guest-path> && cat > report.json <<'EOF'
{"outcome":"working","fault_owner":"repo","operation":"Start the DHP MCP server (dhp-mcp --root <dir>) and dispatch/validate durable work through its tools","operation_scope":"Linux Ubuntu 24.04 guest, Python 3.12.3 in a venv at <guest-path>, pip install -e \".[dev]\" from the pinned checkout. Local stdio MCP only. Kill demo and network chaos not run (need author-specific paths and internet). A successful dhp_dispatch was observed by hand (handoff id returned with ok true); replay checks a malformed-id rejection because the handoff id contains a nonce and changes every run.","steps":["python3 -m venv <guest-path>","<guest-path> -m pip install -q -e \".[dev]\"","<guest-path> -m pytest tests/ -q -p no:warnings --deselect tests/test_adversarial.py::test_kill9_during_writes  (59 passed, 1 deselected)","<guest-path> (10 passed, 0 failed)","<guest-path> --root <guest-path>  (stdio JSON-RPC: tools/call dhp_dispatch -> ok true, handoff_id returned; tools/call dhp_status with malformed id -> ValidationError)","<guest-path> <guest-path> sup1 2  (two scans, leader elected, 0 actions)"],"deviations":["Used a venv because Ubuntu 24.04 blocks system-wide pip (PEP 668); README-required Python >=3.10 is satisfied by 3.12.3.","pip install -e \".[dev]\" created build metadata inside the checkout (egg-info); no product source was edited.","tests/test_adversarial.py::test_kill9_during_writes fails on this VM: the subprocess script hardcodes <host-path> and the test kills the child after a fixed 0.4s sleep, so the DB file was not created before sqlite3.connect (OperationalError). Deselected for the documented pytest example; not fixed in product source.","Pytest output includes an unhandled thread exception: OSError Bad file descriptor from TransportServer's accept loop (dhp/net.py line 177) during teardown. Suppressed in the replayed example with -p no:warnings; the run itself passed 59 tests. This is a real issue in the repo to investigate.","README test count is stale: it says 45 passed; the suite now has 60 tests (59 pass here).","demo/run_mad_demo.py could not run: it opens <host-path> (FileNotFoundError). Not worked around; the path is not created in the guest. scripts/daily_loop.sh has the same hardcoded path and is the author's cron/git-push script, not a product cycle.","The README's MCP promise was verified with dhp_status rejecting a malformed handoff ID rather than with dhp_dispatch's returned handoff ID, because the ID is nonce-based and changes every run; the checker cannot match a random value. The successful dispatch was observed manually with ok true."],"stuck_step":null,"main_blocker":null,"plain_failure":null,"suggested_fix":"Remove hardcoded author paths (<host-path>) from demo/run_mad_demo.py, demo/net_chaos.py, demo/crawl_worker.py and tests/test_adversarial.py (use paths relative to the repo or tempdirs); make the kill-9 test wait for the DB file instead of a fixed sleep; close the TransportServer accept socket cleanly on shutdown so no thread exception is raised; update the README test count."}
EOF
python3 -m json.tool report.json >/dev/null && echo report-ok; cd <guest-path> && <env-var>=<guest-path> timeout 900 python3 -I <guest-path> --validate --replay > <guest-path> 2>&1; echo EXIT=$?; python3 -c "
import json; d=json.load(open('<guest-path>')); print('valid:',d.get('valid')); [print('PROBLEM:',str(p)[:400]) for p in d.get('problems',[])]"; rm -rf <guest-path> <guest-path> <guest-path>