asottile/add-trailing-comma

No problems traced to this repository code in these checks.

Reviewed as expected for a test run: attempted writes that failed, so nothing was written.

OSV scanned supported lockfiles; unpinned dependencies and unsupported formats are outside this check.

A short run cannot establish that code is safe.

Connections show IP addresses; proxies can hide the final hostname.

Tracing covers dispatched commands and their children, not the whole OS; guest root can interfere with tracing.

Full safety evidence →

• adds trailing commas to function calls: Real input produced the expected result: arg2,

  Source: A tool (and pre-commit hook) to automatically add trailing commas to calls and

  Input: x( arg, arg2 )

  Expected: last argument gets a trailing comma

  Command: <guest-path> -

  Observed: arg2, )

• unhugs leading paren and adds trailing comma: Real input produced the expected result: arg2,

  Source: -function_name(arg1,

  Input: function_name(arg1, arg2)

  Expected: arguments are split onto their own lines with trailing comma

  Command: <guest-path> -

  Observed: arg2, )

• removes unnecessary trailing commas: Real input produced the expected result: [1, 2, 3]

  Source: -[1, 2, 3,]

  Input: [1, 2, 3,]

  Expected: trailing comma removed from single-line list

  Command: <guest-path> -

  Observed: [1, 2, 3]

Examples

• repository test suite (documented tox command) passes: command completed successfully

  Source: tox.ini

  Input: tests directory

  Expected: all tests pass

  Command: <guest-path> -m pytest tests

  Observed: ............ [ 47%] tests/features/match_test.py ......... [ 53%] tests/features/pep695_test.py ......... [ 59%] tests/features/remove_commas_test.py ........ [ 64%] tests/features/unhug_test.py ............................. [ 84%] tests/features/with_test.py ........... [ 91%] tests/main_test.py ............ [100%] ============================= 148 passed in 1.62s ==============================

• pre-commit hook usage: pre-commit needs to clone the repo from GitHub and install its own environment; not run in this guest. Ran the CLI hook entry directly instead via the claims above.

  Source: README.md

  Expected: documented command completes successfully

  Observed: pre-commit needs to clone the repo from GitHub and install its own environment; not run in this guest. Ran the CLI hook entry directly instead via the claims above.

Local or hosted: local

Run add-trailing-comma on Python source via its documented CLI (stdin mode) and get trailing commas added; run the test suite

cd <guest-path> && pwd && ls -la && git status 2>&1 | head -3; id -u; python3 --version; cat README.md 2>/dev/null | head -150
ls /inputs 2>&1; ls <guest-path> 2>&1; echo CDP=$CDP_URL $<env-var>
cd <guest-path> && sed -n 150,400p README.md; ls -la .coldpass; cat setup.py tox.ini; cat requirements-dev.txt
cd <guest-path> && grep -n -i "usage\|^#" README.md; sed -n 1,80p add_trailing_comma/_main.py | grep -n "argparse\|add_argument\|def main" ; which pip3 python3; python3 -m venv --help >/dev/null 2>&1 && echo venv_ok
cd <guest-path> && git init -q && git remote add origin https://github.com/asottile/add-trailing-comma && (git fetch --depth 1 origin 4aa21034cf9e0aef19376abd3922943400b16ee1 2>&1 | tail -3) && git reset --mixed FETCH_HEAD 2>&1 | tail -2; git log --oneline -1; python3 -m venv <guest-path> && <guest-path> install -q --upgrade pip && <guest-path> install -q -r requirements-dev.txt && <guest-path> install -q . 2>&1 | tail -5; ls <guest-path> | grep -i trailing
cd <guest-path> && sed -n 1,60p add_trailing_comma/_main.py; sed -n 56,120p add_trailing_comma/_main.py | grep -n "in_place\|print\|write" 
cd <guest-path> && printf 'x(\n    arg,\n    arg2\n)\n' | <guest-path> -; echo rc=$?; printf 'x = [\n    1, 2, 3\n]\n' | <guest-path> -; echo rc=$?; <guest-path> --version; <guest-path> -m pytest -q tests 2>&1 | tail -3
cd <guest-path> && mkdir -p .coldpass && cat > .coldpass/probe.json <<'EOF'
{"kind":"cli","argv":["<guest-path>","-"],"cwd":"<guest-path>","stdin":"x(\n    arg,\n    arg2\n)\n","expected_returncode":1,"expected_text":"    arg2,"}
EOF
cat > .coldpass/claims.json <<'EOF'
[
{"kind":"claim","claim":"adds trailing commas to function calls","source":"A tool (and pre-commit hook) to automatically add trailing commas to calls and","input":"x(\n    arg,\n    arg2\n)\n","expected":"last argument gets a trailing comma","probe_kind":"cli","argv":["<guest-path>","-"],"stdin":"x(\n    arg,\n    arg2\n)\n","expected_returncode":1,"expected_text":"    arg2,","cwd":"<guest-path>"},
{"kind":"claim","claim":"unhugs leading paren and adds trailing comma","source":"-function_name(arg1,","input":"function_name(arg1,\n              arg2)\n","expected":"arguments are split onto their own lines with trailing comma","probe_kind":"cli","argv":["<guest-path>","-"],"stdin":"function_name(arg1,\n              arg2)\n","expected_returncode":1,"expected_text":"    arg2,","cwd":"<guest-path>"},
{"kind":"claim","claim":"removes unnecessary trailing commas","source":"-[1, 2, 3,]","input":"[1, 2, 3,]\n","expected":"trailing comma removed from single-line list","probe_kind":"cli","argv":["<guest-path>","-"],"stdin":"[1, 2, 3,]\n","expected_returncode":1,"expected_text":"[1, 2, 3]","cwd":"<guest-path>"}
]
EOF
cat > .coldpass/examples.json <<'EOF'
[
{"kind":"example","claim":"repository test suite (documented tox command) passes","source":"tox.ini","input":"tests directory","expected":"all tests pass","argv":["<guest-path>","-m","pytest","tests"],"cwd":"<guest-path>","expected_text":"passed"},
{"kind":"example","claim":"pre-commit hook usage","source":"README.md","reason":"pre-commit needs to clone the repo from GitHub and install its own environment; not run in this guest. Ran the CLI hook entry directly instead via the claims above."}
]
EOF
cat > .coldpass/cycles.json <<'EOF'
{"detected":false,"reason":"Entry points inspected (add_trailing_comma/_main.py, setup.py, README.md, tox.ini): this is a one-shot CLI and pre-commit hook with no scheduler, loop, daemon, webhook, or --once/--now mode; it runs once per invocation.","checks":[]}
EOF
<guest-path> -m json.tool .coldpass/*.json >/dev/null -I 2>&1; for f in .coldpass/*.json; do python3 -c "import json,sys;json.load(open(sys.argv[1]))" $f && echo ok $f; done; <env-var>=<guest-path> python3 -I <guest-path> --validate --replay 2>&1 | tail -60
cd <guest-path> && ls -a; ls -d build *.egg-info add_trailing_comma.egg-info 2>/dev/null; git status --short | head; cat > .coldpass/report.json <<'EOF'
{"outcome":"working","fault_owner":null,"operation":"Run add-trailing-comma on Python source via its documented CLI (stdin mode) and get trailing commas added; run the test suite","operation_scope":"Local CLI on Python 3.12.3 in a venv at <guest-path>; install from the local pinned checkout (commit 4aa21034cf9e0aef19376abd3922943400b16ee1); no browser or credentials needed","steps":["git init; git remote add origin https://github.com/asottile/add-trailing-comma; git fetch --depth 1 origin 4aa21034cf9e0aef19376abd3922943400b16ee1; git reset --mixed FETCH_HEAD","python3 -m venv <guest-path>","<guest-path> install -r requirements-dev.txt","<guest-path> install .","printf 'x(\\n    arg,\\n    arg2\\n)\\n' | <guest-path> -","<guest-path> -m pytest tests (148 passed)"],"deviations":["README install is 'pip install add-trailing-comma' from PyPI; instead installed the pinned local source checkout with 'pip install .' so the tested code is the snapshot under review.","pre-commit hook usage in README not run: it requires cloning the repo from GitHub and creating its own environment; the hook entry was exercised through the CLI instead.","The tool exits 1 when it rewrites input (documented in claims as expected_returncode 1); --version is not supported (help-only check, not used as evidence)."],"stuck_step":null,"main_blocker":null,"plain_failure":null,"suggested_fix":null}
EOF
python3 -c "import json;json.load(open('.coldpass/report.json'));print('report ok')"
cd <guest-path> && rm -rf build add_trailing_comma.egg-info .pytest_cache && <env-var>=<guest-path> python3 -I <guest-path> --validate --replay 2>&1 | python3 -c "import sys,json;d=json.loads(sys.stdin.read());print(d['valid'],d['problems'],d['replay']['status'])"